Putting color escape sequences in the log look pretty for the developer but fails in real world DPDK usage. A real application will put DPDK log to syslog, and syslog does not handle escape sequences.
Fixes: dd543124cd93 ("common/octeontx2: add runtime log infra") Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- drivers/common/octeontx2/otx2_common.h | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/common/octeontx2/otx2_common.h b/drivers/common/octeontx2/otx2_common.h index cdb25d9ed203..e53d411f065d 100644 --- a/drivers/common/octeontx2/otx2_common.h +++ b/drivers/common/octeontx2/otx2_common.h @@ -69,12 +69,9 @@ extern int otx2_logtype_tm; extern int otx2_logtype_tim; extern int otx2_logtype_dpi; -#define OTX2_CLNRM "\x1b[0m" -#define OTX2_CLRED "\x1b[31m" - -#define otx2_err(fmt, args...) \ - RTE_LOG(ERR, PMD, ""OTX2_CLRED"%s():%u " fmt OTX2_CLNRM"\n", \ - __func__, __LINE__, ## args) +#define otx2_err(fmt, args...) \ + RTE_LOG(ERR, PMD, "%s():%u " fmt "\n", \ + __func__, __LINE__, ## args) #define otx2_info(fmt, args...) \ RTE_LOG(INFO, PMD, fmt"\n", ## args) -- 2.20.1