> -----Original Message-----
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang
> Sent: Monday, July 15, 2019 10:24 AM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.y...@intel.com>; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH v3] net/ice: fix flow validation fail
>
> ice_flow_valid_attr will return zero on success and a negative value on error.
> Current return value check logical is opposite to the expected behavior. This
> patch fixed this issue.
>
> Fixes: d76116a4678f ("net/ice: add generic flow API")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Qiming Yang <qiming.y...@intel.com>
> ---
> drivers/net/ice/ice_generic_flow.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ice/ice_generic_flow.c
> b/drivers/net/ice/ice_generic_flow.c
> index d5ff278..e6a2c4b 100644
> --- a/drivers/net/ice/ice_generic_flow.c
> +++ b/drivers/net/ice/ice_generic_flow.c
> @@ -549,7 +549,7 @@ static int ice_flow_valid_action(struct rte_eth_dev
> *dev,
> rte_flow_error_set(error, EINVAL,
> RTE_FLOW_ERROR_TYPE_ACTION,
> actions, "Invalid queue ID for"
> - " ethertype_filter.");
> + " switch filter.");
> return -rte_errno;
> }
> break;
> @@ -596,7 +596,7 @@ ice_flow_validate(struct rte_eth_dev *dev,
> }
>
> ret = ice_flow_valid_attr(attr, error);
> - if (!ret)
> + if (ret)
> return ret;
>
> inset = ice_flow_valid_pattern(pattern, error);
> --
> 2.7.4
Acked-by: Beilei Xing <beilei.x...@intel.com>
