Hi Stephen, > -----Original Message----- > From: Stephen Hemminger <[email protected]> > Sent: Monday, July 15, 2019 10:49 AM > To: Carrillo, Erik G <[email protected]> > Cc: [email protected]; [email protected]; [email protected] > Subject: Re: [dpdk-dev] [PATCH 1/2] timer: fix null pointer dereference > > On Mon, 15 Jul 2019 10:39:31 -0500 > Erik Gabriel Carrillo <[email protected]> wrote: > > > If the timer subsystem is not initialized before rte_timer_manage (for > > example) is invoked, a pointer to a shared hugepage memory region will > > still be null and dereferenced when it is checked for validity; handle > > this case. > > > > Fixes: c0749f7096c7 ("timer: allow management in shared memory") > > Cc: [email protected] > > > > Signed-off-by: Erik Gabriel Carrillo <[email protected]> > > I have mixed feelings about this patch. > Any calls to rte_timer before rte_timer_subsystem_init is not a valid usage. > Better to kill the application.
Ok, that sounds like a better approach. I'll update the patch and resubmit. Thanks, Erik
