> -----Original Message----- > From: Hyong Youb Kim <hyon...@cisco.com> > Sent: Monday, July 15, 2019 9:28 PM > To: David Marchand <david.march...@redhat.com>; Thomas Monjalon > <tho...@monjalon.net>; Jerin Jacob Kollanukkaran <jer...@marvell.com>; > Ferruh Yigit <ferruh.yi...@intel.com> > Cc: dev@dpdk.org; John Daley <johnd...@cisco.com>; Hyong Youb Kim > <hyon...@cisco.com> > Subject: [EXT] [RFC PATCH] vfio: avoid re-installing irq handler > > A rough patch for the approach mentioned earlier. It is only for discussion. > http://mails.dpdk.org/archives/dev/2019-July/138113.html > > To try this out, first revert the following then apply. > commit 89aac60e0be9 ("vfio: fix interrupts race condition")
Yes. This patch has to be to reverted. It changes the existing interrupt behavior and does not address the MSIX case as well. I think, The clean fix would be to introduce rte_intr_mask() and rte_intr_unmask() by abstracting the INTX and MSIX differences And let qede driver call it as needed. Thoughts?