From: Thomas Monjalon [mailto:[email protected]] >18/07/2019 16:43, Chautru, Nicolas: >> From: Thomas Monjalon [mailto:[email protected]] >> >3 comments above the change of references: >> > >> >- there are a lot more, please search for the word "section" >> >> All the ones I could see are similar to "as per 3GPP TS 38.212 section >> 5.2.2" which is does not refer to a section within DPDK documentation but to >> external 3GPP specs documents. > >You're right! I completely overlooked it. > >> >- it deserves a separate commit >> >> OK. And you want such a commit now for 19.09 or later on? > >Given there are only 2 figure refs, it can stay with PDF fix. > >> >- the line length should be below 100 chars, better below 80. >> >The ideal is to break lines logically after a punctuation sign, or between >> >"subject" and "verb", etc. >> >Example: >> > Figure :numref:`figure_turbo_tb_encode` above >> > showing the Turbo encoding of CBs using BBDEV interface in TB-mode >> > is also valid for LDPC encode. >> >> All lines are less than 100 chars, but a few places are >80 chars. Let me >> know if you want this changed for 19.09 or later. > >The rule is to not do cosmetic change :) I was explaining the line breaking >for the lines you were changing while fixing figure ref. > >I think I will apply this patch and adjust the line breaking if needed. >Is it OK? >
Ok with me. Thanks Thomas.
