On Thu, Jul 18, 2019 at 8:45 AM <jer...@marvell.com> wrote: > > From: Jerin Jacob <jer...@marvell.com> > > Orginal V1 cover letter from David Marchand: > > Following the issues reported by Jerin and the discussion that emerged > from it, here are fixes to restore and document the behavior of the EAL > and the pci bus driver. > > I pondered all the arguments and tried to have the less changes > possible. > I can't find a need for a flag to just announce support of physical > addresses from the pmd point of view. > So it ended up with something really close to what Jerin had suggested. > > But the problem is that this is still unfinished wrt the documentation. > I will be offline for 10 days and we need this to move forward, so > sending > anyway. > > > v3: > - Patch 2/4 - Remove personal appeals in log messages(Anatoly) > - Patch 4/4 - Added following documentation (Anatoly) > a) #. It is easy to enable large amount of IOVA-contiguous memory use-cases > with IOVA in VA mode. > in the reasons for VA as default > b) As a note, > If the device driver needs IOVA as VA and it cannot work with IOVA > as PA then the driver must request the PCI bus layer using > ``RTE_PCI_DRV_NEED_IOVA_AS_VA`` requirement flag. > Absence of this flag, dictates, the driver must support both IOVA as PA and > VA modes. > > v2: > - Changed RTE_PCI_DRV_IOVA_AS_VA flag name as > RTE_PCI_DRV_NEED_IOVA_AS_VA(patch 3/4) > - Changed IOVA mode as VA for default case(patch 4/4) with documentation > - Tested the patch series on octeontx2 platform
Many thanks to both of you (Jerin, Anatoly) for working on this while I was away. I have some minor comments on the newly added patches, I will send a v4 with the changes in it directly. -- David Marchand
