> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Monday, July 22, 2019 8:07 PM
> To: Yigit, Ferruh <ferruh.yi...@intel.com>; Xing, Beilei
> <beilei.x...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com>
> Cc: dev@dpdk.org; Ye, Xiaolong <xiaolong...@intel.com>; sta...@dpdk.org;
> Li, Xiaoyun <xiaoyun...@intel.com>
> Subject: [PATCH 2/2] net/i40e: fix fdir rule destroy failure
>
> We should tear down the fdir when the last flow is destroyed, current logic is
> opposite to expected behavior, this patch fixes this issue.
>
> Fixes: 2e67a7fbf3ff ("net/i40e: config flow director automatically")
> Cc: sta...@dpdk.org
> Cc: xiaoyun...@intel.com
>
> Signed-off-by: Xiaolong Ye <xiaolong...@intel.com>
> ---
> drivers/net/i40e/i40e_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index
> 3c0af70c0..c60c9e240 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -4771,7 +4771,7 @@ i40e_flow_destroy(struct rte_eth_dev *dev,
> &((struct i40e_fdir_filter *)flow->rule)->fdir, 0);
>
> /* If the last flow is destroyed, disable fdir. */
> - if (!ret && !TAILQ_EMPTY(&pf->fdir.fdir_list)) {
> + if (!ret && TAILQ_EMPTY(&pf->fdir.fdir_list)) {
> i40e_fdir_teardown(pf);
> dev->data->dev_conf.fdir_conf.mode =
> RTE_FDIR_MODE_NONE;
> --
> 2.17.0
Acked-by: Beilei Xing <beilei.x...@intel.com>
