23/07/2019 14:16, Andrew Rybchenko: > On 7/23/19 1:40 PM, Ferruh Yigit wrote: > > On 7/23/2019 10:13 AM, Andrew Rybchenko wrote: > >> rte_eth_dev_info_get() returns void and caller does know if the function > >> does its job or not. Changing of the return value to int would be > >> API/ABI breakage which requires deprecation process and cannot be > >> backported to stable branches. For now, make sure that device info is > >> initialized even in the case of invalid port ID. > > +1 to return a status from function for long term. > > Thomas, what do you think? Should we finally fix it? > I think it is almost harmless API/ABI breakage. > If yes, I'll send deprecation notice to do it in v19.11.
Yes, generally speaking we should not have any void return in API.