> -----Original Message-----
> From: dev <[email protected]> On Behalf Of Bruce Richardson
> Sent: Tuesday, July 30, 2019 3:17 PM
> To: Thomas Monjalon <[email protected]>
> Cc: [email protected]; [email protected]; hgovindh
> <[email protected]>; Marko Kovacevic
> <[email protected]>; Ori Kam <[email protected]>; Pablo de Lara
> <[email protected]>; Radu Nicolau <[email protected]>;
> Akhil Goyal <[email protected]>; Tomasz Kantecki
> <[email protected]>; [email protected];
> [email protected]; [email protected]
> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4] examples/l3fwd: fix unaligned
> memory access
>
> On Tue, Jul 30, 2019 at 10:50:14AM +0200, Thomas Monjalon wrote:
> > Review please?
> >
> > 26/07/2019 15:58, hgovindh:
> > > Fix unaligned memory access when reading IPv6 header which leads to
> > > segmentation fault by changing aligned memory read to unaligned
> > > memory read.
> > >
> > > Bugzilla ID: 279
> > > Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build")
> > > Cc: [email protected]
> > > Cc: [email protected]
> > > Signed-off-by: hgovindh <[email protected]>
> > > --- a/examples/l3fwd/l3fwd_em.c
> > > +++ b/examples/l3fwd/l3fwd_em.c
> > > +#if defined RTE_ARCH_X86
> > > + key.xmm[1] = _mm_loadu_si128(data1); #else
> > > key.xmm[1] = *(xmm_t *)data1;
> > > -
> > > +#endif
> >
>
> The blank line should be re-added below the #ifdef. Apart from that the fix
> looks
> correct to me.
>
> Reviewed-by: Bruce Richardson <[email protected]>
Reviewed-by: Jerin Jacob <[email protected]>
