Hi Bruce, Neil, We had this patch in our internal tree that was intended to fix -Wimplicit-fallthrough related error due to Host and Target GCC mismatch. But I just verified both combination of GCC in Make and Meson seems like it has already been addressed somewhere down the line. So, I'm dropping the patch.
Regards, Pavan. >-----Original Message----- >From: Bruce Richardson <[email protected]> >Sent: Wednesday, July 31, 2019 8:02 PM >To: Pavan Nikhilesh Bhagavatula <[email protected]> >Cc: Jerin Jacob Kollanukkaran <[email protected]>; Neil Horman ><[email protected]>; [email protected]; [email protected] >Subject: [EXT] Re: [dpdk-dev] [PATCH] buildtools: fix pmdinfogen >compilation > >External Email > >---------------------------------------------------------------------- >On Wed, Jul 31, 2019 at 11:57:05AM +0530, [email protected] >wrote: >> From: Pavan Nikhilesh <[email protected]> >> >> Pmdinfogen is always compiled with host gcc. >> If host gcc version is lessthan 7 and target gcc is greaterthan 7 >> pmdinfogen fails to compile due to unsupported cflags. >> This patch removes unsupported host cflags when the above >condition is >> met. >> >> Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen >utility") >> Cc: [email protected] >> >> Signed-off-by: Pavan Nikhilesh <[email protected]> >> --- > >Can you perhaps check with a meson cross-compile and see if you >encounter >the same issue? If so, I'll investigate. > >Thanks, >/Bruce
