> > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Sent: Monday, December 14, 2015 11:04 PM > > To: Liu, Jijiang > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct > > rte_eth_tunnel_flow > > > > 2015-12-09 13:37, Jijiang Liu: > > > The struct 'rte_eth_tunnel_flow' is only used by struct > > > 'rte_eth_fdir_flow' now, but its name is generic, and I plan to > > > extend new > > fileds like below to support generic configuration for tunneling packet. > > > > You have not explained what the changes are for. > > So it's really difficult to have an opinion. > > Please describe an use case. > For i40e flow director, it can use more fields such as inner destination IP, > inner MAC outer destination MAC and outer destination IP to do > classification for tunneling packet. > Otherwise, we also can use this structure to store tunnel flow configuration, > not just for classification. > > > PS: "filed" -> "field"
After aligning with Jingjing, she have already sent ABI change announcement for struct 'rte_eth_fdir_flow'to extend input set of FD, refer to[1]. And change of struct 'rte_eth_tunnel_flow' I want to announce can be included in hers, so I don't need to announce it again. Thanks. [1]http://dpdk.org/ml/archives/dev/2015-November/027915.html