Thomas Monjalon <tho...@monjalon.net> writes: > 31/07/2019 16:50, Aaron Conole: >> From: Michael Santana <msant...@redhat.com> >> --- a/app/test/meson.build >> +++ b/app/test/meson.build >> +if dpdk_conf.has('RTE_LIBRTE_RING_MEMPOOL') >> + test_deps += 'mempool_ring' >> +endif >> +if dpdk_conf.has('RTE_LIBRTE_STACK_MEMPOOL') >> + test_deps += 'mempool_stack' >> +endif >> +if dpdk_conf.has('RTE_LIBRTE_SKELETON_EVENTDEV_PMD') >> + test_deps += 'pmd_skeleton_event' >> +endif >> if dpdk_conf.has('RTE_LIBRTE_PDUMP') >> test_deps += 'pdump' >> endif > > As these libraries are dynamically loadable as plugins, > it should be explained in comments that this explicit linking > is an exception to allow the developer run the unit tests > without intalling the libraries. > Otherwise, other applications will copy it.
Okay. I'll add it.