01/08/2019 14:08, Michał Krawczyk: > czw., 1 sie 2019 o 13:45 Maciej Bielski <[email protected]> napisał(a): > > > > During an if-condition evaluation, a 2-bit flag evaluates to 'true' for > > '0x1', '0x2' and '0x3'. Thus, from this perspective these flags are > > indistinguishable. To make them distinct, respective bits must be > > extracted with a mask and then checked for strict equality. > > > > Specifically here, even if `PKT_TX_UDP_CKSUM` (value '0x3') was set, the > > expression `mbuf->ol_flags & PKT_TX_TCP` (the second flag of value > > '0x1') is evaluated first and the result is 'true'. In consequence, for > > UDP packets the execution flow enters an incorrect branch. > > > > Fixes: 56b8b9b7e5d2 (net/ena: convert to new Tx offloads API) > > Cc: [email protected] > > > > Signed-off-by: Maciej Bielski <[email protected]> > > Reported-by: Eduard Serra <[email protected]> > Acked-by: Michal Krawczyk <[email protected]>
Applied, thanks
