> -----Original Message-----
> From: dev [mailto:[email protected]] On Behalf Of Thomas Monjalon
> Sent: Tuesday, August 6, 2019 12:35 PM
> To: Su, Simei <[email protected]>
> Cc: [email protected]; Zhang, Qi Z <[email protected]>; Wu, Jingjing 
> <[email protected]>; Xing, Beilei <[email protected]>; Yang,
> Qiming <[email protected]>; [email protected]; 
> [email protected]; [email protected]; Yigit, Ferruh
> <[email protected]>
> Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for RSS hash funtion
> 
> 04/07/2019 06:43, simei:
> > From: Simei Su <[email protected]>
> >
> > Add new field SYMMETRIC_TOEPLITZ in rte_eth_hash_function. This
> > can support symmetric hash function by rte_flow RSS action.
> >
> > Signed-off-by: Simei Su <[email protected]>
> > ---
> > +* ethdev: New member in ``rte_eth_hash_funtion`` to support symmetric hash 
> > funtion.
> 
> That's unfortunate there is a typo in the name of the enum you want to change.
> 
> Do you have any reference to the algo you want to support? A paper maybe?

If I am not mistaken that's just an intent to enable symmetric RSS 
hash-function via standard RSS  rte_flow API -
feature already available with i40e and newest Intel HW.
(AFAIK on i40e right now it could be configured via 
RTE_ETH_HASH_FILTER_SYM_HASH_ENA_PER_PORT).
If so, then I think the author may need to mention what PMDs will support that 
feature in 19.11.
Konstantin 

> 
> 

Reply via email to