> -----Original Message----- > From: Sirvys, Andrius > Sent: Thursday, August 8, 2019 3:38 PM > To: Laatz, Kevin <[email protected]> > Cc: [email protected]; [email protected]; Van Haaren, Harry > <[email protected]>; Ferriter, Cian <[email protected]>; > Lipiec, Herakliusz <[email protected]>; Sirvys, Andrius > <[email protected]> > Subject: [PATCH v3] usertools: fix input handling in telemetry script > > This commit removes the unnecesarry ast.literal_eval() function call > from the input handling, which now relies just on raw_input() to get > its input. > > Fixes: 53f293c9a783 ("usertools: replace unsafe input function") > Cc: [email protected] > > Signed-off-by: Andrius Sirvys <[email protected]> > --- > v2: Removed unnecessary comments > v3: Reduced scope of changes only to required Python 2 fix > > Please note that the dpdk-telemetry-client.py script has a number of > issues with Python3 support. Fixing Python3 support is being deferred > to DPDK 19.11 release.
Thanks for the patch re-spin Andrius. This is the smallest change possible to fix the current issue, and I recommend including in 19.08 release. Agree the Python3 support requires larger refactoring, which should be undertaken for 19.11. Acked-by: Harry van Haaren <[email protected]>
