09/08/2019 13:56, Dumitrescu, Cristian:
> From: Singh, Jasvinder
> > In APP_MODE_SRTCM_COLOR_AWARE mode, sample app compilation fails
> > due to wrong meter color type conversion.
> > 
> > Fixes: fc8a10d8527a ("examples/qos_meter: add color policy")

This is not the root cause. Replaced with:

Fixes: c1656328dbc2 ("meter: replace color definitions")
Cc: sta...@dpdk.org

> > error log-
> > /qos_meter/main.c:error: conversion to incomplete type
> > (enum rte_meter_color) input_color);

This log should be before "Fixes" line.

> > Signed-off-by: Jasvinder Singh <jasvinder.si...@intel.com>
> > Reported-by: Peng Yuan <yuan.p...@intel.com>

Reported-by should be before SoB line (chronological order).

> Acked-by: Cristian Dumitrescu <cristian.dumitre...@intel.com>

Applied


Reply via email to