On Sun, Sep 08, 2019 at 08:44:36PM +0100, Stephen Hemminger wrote: > On Fri, 6 Sep 2019 14:05:06 -0500 > Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> wrote: > > > Add templates to support creating ring APIs with different > > ring element sizes. > > > > Signed-off-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> > > Reviewed-by: Dharmik Thakkar <dharmik.thak...@arm.com> > > Reviewed-by: Gavin Hu <gavin...@arm.com> > > Reviewed-by: Ruifeng Wang <ruifeng.w...@arm.com> > > Understand the desire for generic code, but macro's are much harder to > maintain > and debug. Would it be possible to use inline code taking a size argument > and let compiler optimizations with constant folding do the same thing. > > Sorry, I vote NO for large scale use of macro's.
I would tend to agree. This use of macros makes the code very awkward to read and understand.
