Hi
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Monday, September 23, 2019 15:19
> To: Li, Xiaoyun <[email protected]>; Wiles, Keith <[email protected]>;
> Maslekar, Omkar <[email protected]>; Liang, Cunming
> <[email protected]>
> Cc: [email protected]
> Subject: RE: [PATCH v4 4/4] examples/ntb: support more functions for NTB
>
> <...>
>
> > +* ``--qp=N``
> > +
> > + Set the number of queues as N, where qp > 0.
> The default value is 1?
Yes. Will add missing info in doc.
>
> <...>
>
> > +
> > + /* Set default fwd mode if user doesn't set it. */
> > + if (fwd_mode == MAX_FWD_MODE && eth_port_id <
> RTE_MAX_ETHPORTS) {
> > + printf("Set default fwd mode as iofwd.\n");
> > + fwd_mode = IOFWD;
> > + }
> > + if (fwd_mode == MAX_FWD_MODE) {
>
> use "else if"? because (fwd_mode == MAX_FWD_MODE) including (fwd_mode
> == MAX_FWD_MODE && eth_port_id < RTE_MAX_ETHPORTS)
No. If it is that case, the fwd_mode will be set as IOFWD in the first if and
won't hit this one.
>
> Thanks
> Jingjing
