Thanks for the comments. Old version patches' states are changed.

-----Original Message-----
From: Gavin Hu (Arm Technology China) [mailto:[email protected]] 
Sent: Wednesday, September 25, 2019 11:20 AM
To: Cao, Yahui <[email protected]>; Yang, Qiming <[email protected]>; Lu, 
Wenzhuo <[email protected]>
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Ye, Xiaolong 
<[email protected]>; Xing, Beilei <[email protected]>; nd <[email protected]>
Subject: RE: [dpdk-dev] [PATCH v3 1/8] net/ice: enable flow director engine

Hi Yahui,

two general comments: 
1.Please make old versions of patches Superseded to facilitate review.
2. the two occurrences of rte_wmb can be removed, a similar patch has been 
reviewed by Qi. http://patches.dpdk.org/patch/59278/ 

/Gavin

> -----Original Message-----
> From: dev <[email protected]> On Behalf Of Yahui Cao
> Sent: Wednesday, September 25, 2019 5:53 AM
> To: Qiming Yang <[email protected]>; Wenzhuo Lu 
> <[email protected]>
> Cc: [email protected]; Qi Zhang <[email protected]>; Xiaolong Ye 
> <[email protected]>; Beilei Xing <[email protected]>; Yahui 
> Cao <[email protected]>
> Subject: [dpdk-dev] [PATCH v3 1/8] net/ice: enable flow director 
> engine
> 
> From: Beilei Xing <[email protected]>
> 
> Enable flow director engine, including initialization and teardown.
>  - Control VSI create and release.
>  - Queue pair allocated, set up and release.
>  - Programming packet create and release.
>  - FDIR profile create and release.
> 
> Signed-off-by: Beilei Xing <[email protected]>
> ---

Reply via email to