Re: [dpdk-dev] [PATCH v2 05/10] crypto/aesni_mb: add rte_security handler

[Ananyev, Konstantin]

> 
> +     /* setup security operations */
> +     snprintf(sec_name, sizeof(sec_name) - 1, "aes_mb_sec_%u",
> +                     dev->driver_id);

Just a nit here and in aesni_gcm code:
this is useless actually, rte_malloc ignores name argument.
You can safely pass NULL here.


> +     sec_ctx = rte_zmalloc_socket(sec_name,
> +                     sizeof(struct rte_security_ctx),
> +                     RTE_CACHE_LINE_SIZE, init_params->socket_id);
> +     if (sec_ctx == NULL) {
> +             AESNI_MB_LOG(ERR, "memory allocation failed\n");
> +             goto error_exit;
> +     }
> +
> +     sec_ctx->device = (void *)dev;
> +     sec_ctx->ops = rte_aesni_mb_pmd_security_ops;
> +     dev->security_ctx = sec_ctx;
> +
>       return 0;
> 
>  error_exit:
>       if (mb_mgr)
>               free_mb_mgr(mb_mgr);
> +     if (sec_ctx)
> +             rte_free(sec_ctx);
> 
>       rte_cryptodev_pmd_destroy(dev);
>