>-----Original Message----- >From: Ferruh Yigit <ferruh.yi...@intel.com> >Sent: Friday, October 11, 2019 7:18 PM >To: Ananyev, Konstantin <konstantin.anan...@intel.com>; Hemant >Agrawal <hemant.agra...@nxp.com>; Pavan Nikhilesh Bhagavatula ><pbhagavat...@marvell.com>; Sachin Saxena ><sachin.sax...@nxp.com>; Akhil Goyal <akhil.go...@nxp.com>; Igor >Russkikh <igor.russk...@aquantia.com>; Pavel Belous ><pavel.bel...@aquantia.com>; Ravi Kumar <ravi1.ku...@amd.com>; >Rasesh Mody <rm...@marvell.com>; Shahed Shaikh ><shsha...@marvell.com>; Rahul Lakkireddy ><rahul.lakkire...@chelsio.com>; Marcin Wojtas <m...@semihalf.com>; >Michal Krawczyk <m...@semihalf.com>; Guy Tzalik ><gtza...@amazon.com>; Evgeny Schemeilin <evge...@amazon.com>; >Igor Chauskin <igo...@amazon.com>; John Daley ><johnd...@cisco.com>; Hyong Youb Kim <hyon...@cisco.com>; Wei >Hu (Xavier) <xavier.hu...@huawei.com>; Min Hu (Connor) ><humi...@huawei.com>; Yisen Zhuang <yisen.zhu...@huawei.com>; >Xing, Beilei <beilei.x...@intel.com>; Zhang, Qi Z ><qi.z.zh...@intel.com>; Wu, Jingjing <jingjing...@intel.com>; Lu, >Wenzhuo <wenzhuo...@intel.com>; Yang, Qiming ><qiming.y...@intel.com>; Alejandro Lucero ><alejandro.luc...@netronome.com>; Andrew Rybchenko ><arybche...@solarflare.com>; Jerin Jacob Kollanukkaran ><jer...@marvell.com>; Maciej Czekaj <mcze...@marvell.com>; Xu, >Rosen <rosen...@intel.com>; Zhang, Tianfei ><tianfei.zh...@intel.com> >Cc: dev@dpdk.org >Subject: Re: [dpdk-dev] [PATCH 2/3] drivers: use RTE_DIM instead >of ARRAY_SIZE >On 10/11/2019 10:32 AM, Ananyev, Konstantin wrote: >> >> >>> Hi Pavan, >>> >>>> >>>> From: Pavan Nikhilesh <pbhagavat...@marvell.com> >>>> >>>> Use RTE_DIM instead of re-defining ARRAY_SIZE. >>>> >>>> Signed-off-by: Pavan Nikhilesh <pbhagavat...@marvell.com> >>>> --- >>>> drivers/bus/dpaa/base/qbman/qman.c | 6 ++-- >>>> drivers/bus/dpaa/include/compat.h | 5 ---- >>>> drivers/crypto/dpaa2_sec/hw/compat.h | 8 ----- >>>> drivers/crypto/dpaa2_sec/hw/rta/jump_cmd.h | 6 ++-- >>>> drivers/crypto/dpaa2_sec/hw/rta/nfifo_cmd.h | 2 +- >>>> drivers/net/atlantic/atl_hw_regs.h | 1 - >>>> drivers/net/atlantic/hw_atl/hw_atl_utils.c | 4 +-- >>>> .../net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 2 +- >>>> drivers/net/axgbe/axgbe_common.h | 3 -- >>>> drivers/net/axgbe/axgbe_dev.c | 2 +- >>>> drivers/net/bnx2x/bnx2x.c | 6 ++-- >>>> drivers/net/bnx2x/bnx2x.h | 6 ---- >>>> drivers/net/bnx2x/ecore_init.h | 8 ++--- >>>> drivers/net/bnx2x/ecore_sp.c | 2 +- >>>> drivers/net/bnx2x/elink.c | 14 ++++----- >>>> drivers/net/bnx2x/elink.h | 1 - >>>> drivers/net/cxgbe/base/t4_hw.c | 16 +++++----- >>>> drivers/net/cxgbe/base/t4vf_hw.c | 4 +-- >>>> drivers/net/cxgbe/cxgbe_compat.h | 2 -- >>>> drivers/net/cxgbe/cxgbe_flow.c | 4 +-- >>>> drivers/net/cxgbe/cxgbe_main.c | 10 +++---- >>>> drivers/net/cxgbe/sge.c | 2 +- >>>> drivers/net/ena/ena_ethdev.c | 8 ++--- >>>> drivers/net/enic/base/vnic_dev.c | 4 +-- >>>> drivers/net/enic/base/vnic_devcmd.h | 2 -- >>>> drivers/net/hns3/hns3_cmd.c | 2 +- >>>> drivers/net/hns3/hns3_ethdev.h | 2 -- >>>> drivers/net/hns3/hns3_flow.c | 18 +++++------ >>>> drivers/net/i40e/base/i40e_diag.c | 2 +- >>>> drivers/net/i40e/base/i40e_osdep.h | 2 -- >>>> drivers/net/iavf/base/iavf_osdep.h | 2 -- >>>> drivers/net/ice/base/ice_fdir.c | 2 +- >>>> drivers/net/ice/base/ice_flex_pipe.c | 2 +- >>>> drivers/net/ice/base/ice_flow.c | 2 +- >>>> drivers/net/ice/base/ice_osdep.h | 1 - >>>> drivers/net/ice/base/ice_switch.c | 2 +- >>>> .../net/nfp/nfpcore/nfp-common/nfp_platform.h | 4 --- >>>> drivers/net/nfp/nfpcore/nfp_cppcore.c | 2 +- >>>> drivers/net/nfp/nfpcore/nfp_nsp.c | 2 +- >>>> drivers/net/nfp/nfpcore/nfp_nsp_eth.c | 4 +-- >>>> drivers/net/sfc/base/ef10_ev.c | 4 +-- >>>> drivers/net/sfc/base/ef10_filter.c | 12 ++++---- >>>> drivers/net/sfc/base/ef10_mac.c | 18 +++++------ >>>> drivers/net/sfc/base/ef10_nic.c | 4 +-- >>>> drivers/net/sfc/base/ef10_nvram.c | 6 ++-- >>>> drivers/net/sfc/base/efx.h | 3 -- >>>> drivers/net/sfc/base/efx_port.c | 2 +- >>>> drivers/net/sfc/base/efx_rx.c | 2 +- >>>> drivers/net/sfc/base/siena_mac.c | 2 +- >>>> drivers/net/sfc/base/siena_nic.c | 20 ++++++------- >>>> drivers/net/sfc/base/siena_nvram.c | 6 ++-- >>>> drivers/net/thunderx/base/nicvf_hw.c | 30 +++++++++-------- >-- >>>> drivers/net/thunderx/base/nicvf_hw.h | 2 -- >>>> .../raw/ifpga/base/osdep_rte/osdep_generic.h | 2 -- >>>> 54 files changed, 120 insertions(+), 170 deletions(-) >>>> >>>> diff --git a/drivers/bus/dpaa/base/qbman/qman.c >>>> b/drivers/bus/dpaa/base/qbman/qman.c >>>> index e43fc65ef..019be95e2 100644 >>>> --- a/drivers/bus/dpaa/base/qbman/qman.c >>>> +++ b/drivers/bus/dpaa/base/qbman/qman.c >>>> @@ -1956,7 +1956,7 @@ int qman_query_wq(u8 >query_dedicated, struct >>>> qm_mcr_querywq *wq) >>>> int i, array_len; >>>> >>>> wq->channel.id = be16_to_cpu(mcr- >>querywq.channel.id); >>>> - array_len = ARRAY_SIZE(mcr->querywq.wq_len); >>>> + array_len = RTE_DIM(mcr->querywq.wq_len); >>> >>> [Hemant] some of these files are common Flibs and they are shared >with other projects (Linux/uboot) etc. It will be more appropriate to >>> map the ARRAY_SIZE to RTE_DIM in compat.h instead of changing >this code inline. >>> This way we need not to maintain diff from the common HW lib >codes. >> >> +1 to this suggestion >> > >What about dropping the drivers patch form this patchset but continue >with others?
I will drop the drivers patch from this patchset and send v2 for the rest. Pavan.
