On Tue, Oct 15, 2019 at 10:56 AM Pavan Nikhilesh Bhagavatula <[email protected]> wrote: > > > > >-----Original Message----- > >From: David Marchand <[email protected]> > >Sent: Tuesday, October 15, 2019 2:16 PM > >To: Jerin Jacob Kollanukkaran <[email protected]>; Stephen > >Hemminger <[email protected]> > >Cc: dev <[email protected]>; Pavan Nikhilesh Bhagavatula > ><[email protected]>; dpdk stable <[email protected]>; Aaron > >Conole <[email protected]> > >Subject: Re: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one > >when divisor is 32bit > >On Tue, Sep 3, 2019 at 9:17 PM <[email protected]> wrote: > >> > >> From: Pavan Nikhilesh <[email protected]> > >> > >> Fix off by one error in 64bit reciprocal division when divisor is 32bit. > >> > >> Fixes: 6d45659eacb8 ("eal: add u64-bit variant for reciprocal divide") > >> Cc: [email protected] > >> > >> Signed-off-by: Pavan Nikhilesh <[email protected]> > > > >Any review? > > > >Are we missing an update in the unit test to catch this issue? > >Thanks. > > We actually caught it in a unit test > >test_reciprocal_division
We had this problem since the very start then. Both reciprocal_division and reciprocal_division_perf are in the "perf" list. Can they be promoted to the standard list? -- David Marchand
