> -----Original Message----- > From: David Marchand <david.march...@redhat.com> > Sent: Monday, October 14, 2019 11:45 PM > To: Phil Yang (Arm Technology China) <phil.y...@arm.com> > Cc: tho...@monjalon.net; jer...@marvell.com; Gage Eads > <gage.e...@intel.com>; dev <dev@dpdk.org>; hemant.agra...@nxp.com; > Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>; Gavin Hu (Arm > Technology China) <gavin...@arm.com>; nd <n...@arm.com> > Subject: Re: [dpdk-dev] [PATCH v9 3/3] eal/stack: enable lock-free stack for > aarch64 > > On Wed, Aug 14, 2019 at 10:30 AM Phil Yang <phil.y...@arm.com> wrote: > > > > Enable both c11 atomic and non c11 atomic lock-free stack for aarch64. > > > > Introduced a new header to reduce the ifdef clutter across generic and c11 > > files. The rte_stack_lf_stubs.h contains stub implementations of > > __rte_stack_lf_count, __rte_stack_lf_push_elems and > > __rte_stack_lf_pop_elems. > > > > Suggested-by: Gage Eads <gage.e...@intel.com> > > Suggested-by: Jerin Jacob <jer...@marvell.com> > > Signed-off-by: Phil Yang <phil.y...@arm.com> > > Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> > > Tested-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> > > Acked-by: Jerin Jacob <jer...@marvell.com> > > ---
<snip> > > ------------- > > diff --git a/lib/librte_stack/Makefile b/lib/librte_stack/Makefile > > index 8d18ce5..c337ab7 100644 > > --- a/lib/librte_stack/Makefile > > +++ b/lib/librte_stack/Makefile > > @@ -24,6 +24,7 @@ SYMLINK-$(CONFIG_RTE_LIBRTE_STACK)-include := > rte_stack.h \ > > rte_stack_std.h \ > > rte_stack_lf.h \ > > rte_stack_lf_generic.h \ > > - rte_stack_lf_c11.h > > + rte_stack_lf_c11.h \ > > + rte_stack_lf_stubs.h > > Please, use the same indentation type than the other lines. Updated in v10. Thanks, Phil