Hi Thomas Yes, I agree with you. Documentation is needed. I will update it soon later together with others I need to update. Thanks for your reminder!
Regards, Helin > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, February 2, 2015 10:57 PM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v9 5/5] app/testpmd: add commands to support > hash functions > > 2015-01-22 15:36, Helin Zhang: > > To demonstrate the hash filter control, commands are added. > > They are, > > - get_sym_hash_ena_per_port > > - set_sym_hash_ena_per_port > > - get_hash_global_config > > - set_hash_global_config > > > > Signed-off-by: Helin Zhang <helin.zhang at intel.com> > > --- > > app/test-pmd/cmdline.c | 333 > > +++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 333 insertions(+) > > The new testpmd functions should be documented in > doc/guides/testpmd_app_ug/testpmd_funcs.rst. > The patch won't be blocked waiting for documentation because it is an old > patchset and the doc requirement is newer. > Please, don't forget to submit a doc patch. > -- > Thomas
