Re: [dpdk-dev] [PATCH v5 1/3] lib/ring: apis to support configurable element size

[Stephen Hemminger]

On Thu, 17 Oct 2019 15:08:05 -0500
Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> wrote:

> +     if ((esize != 4) && (esize != 8) && (esize != 16)) {
> +             RTE_LOG(ERR, RING,
> +                     "Unsupported esize value. Supported values are 4, 8 and 
> 16\n");
> +
> +             return -EINVAL;
> +     }
> +
>       /* count must be a power of 2 */
>       if ((!POWEROF2(count)) || (count > RTE_RING_SZ_MASK )) {

Minor nit, you don't need as many parens in conditionals.

        if (esize != 4 && esize != 8 && esize != 16) {

and
        if (!POWEROF2(count) || count > RTE_RING_SZ_MASK) {