Hi Abhinandan, > -----Original Message----- > From: Gujjar, Abhinandan S <abhinandan.guj...@intel.com> > Sent: Friday, October 4, 2019 3:06 PM > To: Hemant Agrawal <hemant.agra...@nxp.com>; dev@dpdk.org > Cc: jer...@marvell.com > Subject: RE: [PATCH 1/6] test/event_crypto: fix missing IV value for AES algo > Importance: High > > Hi Hemanth, > > I tried to test the series of patches on test with SW adapter. > Looks like, test hangs after 3rd case! > Not sure, if I am missing any params to be passed to the app or anything else > has to be done.
[Hemant] OK, let me split this series into 2. I will send the restructuring patch separately post rework. Most likely that patch is causing hang on x86. > > + ------------------------------------------------------- + > + TestCase [ 0] : test_crypto_adapter_create succeeded + TestCase [ 1] : > test_crypto_adapter_qp_add_del succeeded +----------------------------------- > -------------------+ > + Crypto adapter stats for instance 0: > + Event port poll count 0 > + Event dequeue count 0 > + Cryptodev enqueue count 0 > + Cryptodev enqueue failed count 0 > + Cryptodev dequeue count 0 > + Event enqueue count 0 > + Event enqueue retry count 0 > + Event enqueue fail count 0 > +------------------------------------------------------+ > + TestCase [ 2] : test_crypto_adapter_stats succeeded > > > > -----Original Message----- > > From: Hemant Agrawal <hemant.agra...@nxp.com> > > Sent: Tuesday, October 1, 2019 5:04 PM > > To: dev@dpdk.org > > Cc: jer...@marvell.com; Gujjar, Abhinandan S > > <abhinandan.guj...@intel.com> > > Subject: [PATCH 1/6] test/event_crypto: fix missing IV value for AES > > algo > > > > The IV was not set, which was causing HW based SEC on DPAA1 to fail. > > > > Fixes: ce02103ad072 ("test/event_crypto: change the SEC cipher algo") > > > > Signed-off-by: Hemant Agrawal <hemant.agra...@nxp.com> > > --- > > Please squash if possible. > > > > app/test/test_event_crypto_adapter.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/app/test/test_event_crypto_adapter.c > > b/app/test/test_event_crypto_adapter.c > > index 652e458f0..bf83a6357 100644 > > --- a/app/test/test_event_crypto_adapter.c > > +++ b/app/test/test_event_crypto_adapter.c > > @@ -171,6 +171,7 @@ test_op_forward_mode(uint8_t session_less) > > struct rte_event ev; > > uint32_t cap; > > int ret; > > + uint8_t cipher_key[17]; > > > > memset(&m_data, 0, sizeof(m_data)); > > > > @@ -186,6 +187,11 @@ test_op_forward_mode(uint8_t session_less) > > cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC; > > cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT; > > > > + cipher_xform.cipher.key.data = cipher_key; > > + cipher_xform.cipher.key.length = 16; > > + cipher_xform.cipher.iv.offset = IV_OFFSET; > > + cipher_xform.cipher.iv.length = 16; > > + > > op = rte_crypto_op_alloc(params.op_mpool, > > RTE_CRYPTO_OP_TYPE_SYMMETRIC); > > TEST_ASSERT_NOT_NULL(op, > > @@ -364,6 +370,7 @@ test_op_new_mode(uint8_t session_less) > > struct rte_mbuf *m; > > uint32_t cap; > > int ret; > > + uint8_t cipher_key[17]; > > > > memset(&m_data, 0, sizeof(m_data)); > > > > @@ -379,6 +386,11 @@ test_op_new_mode(uint8_t session_less) > > cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC; > > cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT; > > > > + cipher_xform.cipher.key.data = cipher_key; > > + cipher_xform.cipher.key.length = 16; > > + cipher_xform.cipher.iv.offset = IV_OFFSET; > > + cipher_xform.cipher.iv.length = 16; > > + > > op = rte_crypto_op_alloc(params.op_mpool, > > RTE_CRYPTO_OP_TYPE_SYMMETRIC); > > TEST_ASSERT_NOT_NULL(op, "Failed to allocate crypto_op!\n"); > > -- > > 2.17.1