Hi, Xiaolong
Thanks.
This will be fixed in v10.
-----Original Message-----
From: Ye, Xiaolong
Sent: Saturday, October 19, 2019 8:57 AM
To: Pei, Andy <andy....@intel.com>
Cc: dev@dpdk.org; Xu, Rosen <rosen...@intel.com>; Zhang, Tianfei
<tianfei.zh...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com>
Subject: Re: [PATCH v9 13/18] raw/ifpga/base: add secure support
On 10/14, Andy Pei wrote:
>From: Tianfei zhang <tianfei.zh...@intel.com>
>
>Add secure max10 device support.
>
>Signed-off-by: Tianfei zhang <tianfei.zh...@intel.com>
>Signed-off-by: Andy Pei <andy....@intel.com>
>---
> drivers/raw/ifpga/base/ifpga_defines.h | 2 +
> drivers/raw/ifpga/base/ifpga_fme.c | 26 ++++--
> drivers/raw/ifpga/base/opae_intel_max10.c | 136
>+++++++++++++++++++++++++-----
>drivers/raw/ifpga/base/opae_intel_max10.h | 80 +++++++++++++-----
> 4 files changed, 197 insertions(+), 47 deletions(-)
>
>+static int
>+max10_secure_hw_init(struct intel_max10_device *dev) {
>+ int offset, sysmgr_offset = 0;
>+ char *fdt_root;
>+
>+ fdt_root = dev->fdt_root;
>+ if (!fdt_root) {
>+ dev_debug(dev, "skip init as not find Device Tree\n");
>+ return 0;
>+ }
>+
>+ fdt_for_each_subnode(offset, fdt_root, 0) {
>+ if (!fdt_node_check_compatible(fdt_root, offset,
>+ "intel-max10,system-manager"))
>+ sysmgr_offset = offset;
>+ break;
>+ }
Do you miss a brace for the if block? See compilation error below:
dpdk/drivers/raw/ifpga/base/opae_intel_max10.c:541:3: error: this ‘if’ clause
does not guard... [-Werror=misleading-indentation]
if (!fdt_node_check_compatible(fdt_root, offset,
^~
/home/yexl/workspace/dpdk/drivers/raw/ifpga/base/opae_intel_max10.c:544:4:
note: ...this statement, but the latter is misleadingly indented as if it were
guarded by the ‘if’
break;
^~~~~
