On 25/10/2019 04:39, Min, JiaqiX wrote: > Hi Xiaolong, > >> -----Original Message----- >> From: Ye, Xiaolong >> Sent: Friday, October 25, 2019 11:06 AM >> To: Min, JiaqiX <jiaqix....@intel.com> >> Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo...@intel.com>; Yang, Qiming >> <qiming.y...@intel.com> >> Subject: Re: [dpdk-dev] [PATCH] net/ice: set max frame size >> >> Hi, >> >> Could you provide the Fixes tag and cc stable? >> > > It's a persistent issue, maybe it is an implementation miss. > So Fixes tag can't be provided. Like this, need cc stable? >
If it is an implementation miss since the driver was written then please set the Fixes tag to the commit where the driver was introduced. >> Thanks, >> >> >> On 10/24, Min JiaqiX wrote: >>> Max frame size is not set to HW, so packets above the MTU do not get >>> dropped by HW. The patch fixed the issue. >>> >>> Signed-off-by: Min JiaqiX <jiaqix....@intel.com> >>> --- >>> drivers/net/ice/ice_ethdev.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/drivers/net/ice/ice_ethdev.c >>> b/drivers/net/ice/ice_ethdev.c index 022b58c01..403305cfb 100644 >>> --- a/drivers/net/ice/ice_ethdev.c >>> +++ b/drivers/net/ice/ice_ethdev.c >>> @@ -2506,6 +2506,10 @@ ice_dev_start(struct rte_eth_dev *dev) >>> >>> pf->adapter_stopped = false; >>> >>> + /* Set the max frame size */ >>> + ice_aq_set_mac_cfg(hw, >>> + pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL); >>> + >>> return 0; >>> >>> /* stop the started queues if failed to start all queues */ >>> -- >>> 2.17.1 >>>
