25/10/2019 14:51, Ferruh Yigit: > Also filter definitions should be clarified more in the features > documentation so that all PMDs can easily figure out to announce or > not these filtering features, also users can understand better what to > expect from this feature.
OK let's try to dig in some descriptions. [...] > +N-tuple filter > +-------------- > + > +Supports filtering on N-tuple values. What is n-tuple? 3-tuple is enough? > +Tunnel filter > +------------- > + > +Supports tunnel filtering. There are so many kinds of tunnels and filtering. What is minimum to declare such feature? Isn't it more relevant to list the supported tunnels? > +Flexible filter > +--------------- > + > +Supports a flexible (non-tuple or Ethertype) filter. This is meaningless and should be dropped for sure. > +* **[implements] eth_dev_ops**: ``filter_ctrl:RTE_ETH_FILTER_FLEXIBLE``. > +* **[related] API**: ``rte_eth_dev_filter_ctrl()``, > ``rte_eth_dev_filter_supported()``. You are referring to the deprecated API here and in other places. > +Hash filter > +----------- > + > +Supports Hash filtering. Which hash? > +Flow director > +------------- > + > +Supports Flow Director style filtering to queues. I think it is an Intel wording. Could you describe it with networking words?