Hi Konstantin, Please see inline.
Thanks, Anoob > -----Original Message----- > From: Ananyev, Konstantin <[email protected]> > Sent: Friday, October 25, 2019 3:10 PM > To: Anoob Joseph <[email protected]>; Akhil Goyal > <[email protected]>; Nicolau, Radu <[email protected]> > Cc: Thomas Monjalon <[email protected]>; Jerin Jacob Kollanukkaran > <[email protected]>; Narayana Prasad Raju Athreya > <[email protected]>; Lukas Bartosik <[email protected]>; > [email protected] > Subject: [EXT] RE: [dpdk-dev] [RFC PATCH 00/13] add eventmode to ipsec- > secgw > > External Email > > ---------------------------------------------------------------------- > > <snip> > > > > > > > > > This series is targeted for next release (20.02). This series > > > > doesn't introduce any library change. > > > > > > By 'library change' you mean that this new event-mode will be > > > supported only by legacy code-path or ...? > > > > [Anoob] All the changes are confined to 'examples/ipsec-secgw' > > directory. Right now, the worker threads make use of the existing routines > in non-librte_ipsec mode. > > And as I understand, you don't plan to use/support library mode? > I suppose I need to look to the actual code to understand more here. [Anoob] Supporting library mode is also in the pipeline. But initial target would be support with non-librte_ipsec mode. > > > > > > > > > >And the decision to add eventmode additions in ipsec-secgw was > > > >approved by the Tech Board. > > > > > > > > Following are missing in the RFC. Will add it when sending patches. > > > > 1. Documentation. > > > > 2. More cleanup is needed. There are options that are added so that > future > > > > expansion is not hindered. Need inputs from the community if > > > > there is > > > use > > > > case for them. > > > > > > > > Following are planned features, > > > > 1. Add burst mode workers. > > > > 2. Add non tx internal port worker. > > > > 3. Verify support for Rx core (the support is added but lack of > > > > h/w to > > > verify). > > > > 4. Add lookaside protocol support. > > > > > > > > Following are features that Marvell won't be attempting. > > > > 1. Inline crypto support. > > > > 2. Lookaside crypto support. > > > > > > Ok so what mode is supported right now with this RFC? > > > > [Anoob] Inline protocol support is added with the RFC. > > Ok..., but do we have within DPDK any PMD that implements inline-proto? > AFAIK we don't, but might be I am missing something? [Anoob] Inline protocol support would be added to OCTEON TX2 eth PMD in the next cycle. This is an RFC to introduce the idea of using events in ipsec-segcw, which is required for OCTEON TX2 platform to perform inline ipsec processing. > > > > > > > > > > > > > > For the features that Marvell won't be attempting, new workers can > > > > be introduced by the respective stake holders. > > > > > > > > Anoob Joseph (13): > > > > examples/ipsec-secgw: add framework for eventmode helper > > > > examples/ipsec-secgw: add eventdev port-lcore link > > > > examples/ipsec-secgw: add Rx adapter support > > > > examples/ipsec-secgw: add Tx adapter support > > > > examples/ipsec-secgw: add routines to display config > > > > examples/ipsec-secgw: add routines to launch workers > > > > examples/ipsec-secgw: add support for internal ports > > > > examples/ipsec-secgw: add eventmode to ipsec-secgw > > > > examples/ipsec-secgw: add app inbound worker > > > > examples/ipsec-secgw: add app processing code > > > > examples/ipsec-secgw: add driver outbound worker > > > > examples/ipsec-secgw: add app outbound worker > > > > examples/ipsec-secgw: add cmd line option for bufs > > > > > > > > examples/ipsec-secgw/Makefile | 2 + > > > > examples/ipsec-secgw/event_helper.c | 1757 > > > > +++++++++++++++++++++++++++++++++++ > > > > examples/ipsec-secgw/event_helper.h | 334 +++++++ > > > > examples/ipsec-secgw/ipsec-secgw.c | 436 +++++++-- > > > > examples/ipsec-secgw/ipsec-secgw.h | 81 ++ > > > > examples/ipsec-secgw/ipsec.c | 4 + > > > > examples/ipsec-secgw/ipsec.h | 30 +- > > > > examples/ipsec-secgw/ipsec_worker.c | 766 +++++++++++++++ > > > > examples/ipsec-secgw/ipsec_worker.h | 39 + > > > > examples/ipsec-secgw/meson.build | 4 +- > > > > examples/ipsec-secgw/sa.c | 11 - > > > > 11 files changed, 3360 insertions(+), 104 deletions(-) create > > > > mode > > > > 100644 examples/ipsec-secgw/event_helper.c > > > > create mode 100644 examples/ipsec-secgw/event_helper.h > > > > create mode 100644 examples/ipsec-secgw/ipsec-secgw.h > > > > create mode 100644 examples/ipsec-secgw/ipsec_worker.c > > > > create mode 100644 examples/ipsec-secgw/ipsec_worker.h > > > > > > > > -- > > > > 2.7.4
