Hi Bernard, PSB. > -----Original Message----- > From: Iremonger, Bernard <[email protected]> > Sent: Wednesday, November 6, 2019 6:41 PM > To: Dekel Peled <[email protected]>; Mcnamara, John > <[email protected]>; Kovacevic, Marko > <[email protected]>; [email protected]; > [email protected]; [email protected]; Burakov, > Anatoly <[email protected]>; [email protected]; > [email protected]; [email protected]; Lu, Wenzhuo > <[email protected]>; Ananyev, Konstantin > <[email protected]>; Matan Azrad <[email protected]>; > Shahaf Shuler <[email protected]>; Slava Ovsiienko > <[email protected]>; [email protected]; > [email protected]; [email protected]; Bie, Tiwei > <[email protected]>; Wang, Zhihong <[email protected]>; > [email protected]; Thomas Monjalon <[email protected]>; Yigit, > Ferruh <[email protected]>; [email protected]; Wu, Jingjing > <[email protected]> > Cc: [email protected] > Subject: RE: [PATCH v3 0/3] support API to set max LRO packet size > > Hi Dekel, > > > -----Original Message----- > > From: Dekel Peled <[email protected]> > > Sent: Wednesday, November 6, 2019 2:28 PM > > To: Mcnamara, John <[email protected]>; Kovacevic, Marko > > <[email protected]>; [email protected]; > > [email protected]; [email protected]; Burakov, > > Anatoly <[email protected]>; [email protected]; > > [email protected]; [email protected]; Lu, > Wenzhuo > > <[email protected]>; Ananyev, Konstantin > > <[email protected]>; [email protected]; > > [email protected]; [email protected]; > [email protected]; > > [email protected]; [email protected]; Bie, Tiwei > > <[email protected]>; Wang, Zhihong <[email protected]>; > > [email protected]; [email protected]; Yigit, Ferruh > > <[email protected]>; [email protected]; Wu, Jingjing > > <[email protected]>; Iremonger, Bernard > > <[email protected]> > > Cc: [email protected] > > Subject: [PATCH v3 0/3] support API to set max LRO packet size > > > > This series implements support and use of API for configuration and > > validation of max size for LRO aggregated packet. > > > > v2: Updated ethdev patch per review comments. > > v3: Updated ethdev and testpmd patches per review comments. > > My comments on the v2 testpmd patch have not been addressed in the v3 > patch.
I accepted your comment about update of function usage(), and added it in v3. I replied your other comments in v2 reply email, and didn't see additional response. Regards, Dekel > > > > > Dekel Peled (3): > > ethdev: support API to set max LRO packet size > > net/mlx5: use API to set max LRO packet size > > app/testpmd: use API to set max LRO packet size > > > > app/test-pmd/cmdline.c | 73 > > +++++++++++++++++++++++++++++ > > app/test-pmd/config.c | 2 + > > app/test-pmd/parameters.c | 7 +++ > > app/test-pmd/testpmd.c | 1 + > > doc/guides/nics/features.rst | 2 + > > doc/guides/nics/mlx5.rst | 2 + > > doc/guides/rel_notes/deprecation.rst | 4 -- > > doc/guides/rel_notes/release_19_11.rst | 8 ++++ > > doc/guides/testpmd_app_ug/run_app.rst | 5 ++ > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 ++++ > > drivers/net/bnxt/bnxt_ethdev.c | 1 + > > drivers/net/hinic/hinic_pmd_ethdev.c | 1 + > > drivers/net/ixgbe/ixgbe_ethdev.c | 2 + > > drivers/net/ixgbe/ixgbe_vf_representor.c | 1 + > > drivers/net/mlx5/mlx5.h | 3 ++ > > drivers/net/mlx5/mlx5_ethdev.c | 1 + > > drivers/net/mlx5/mlx5_rxq.c | 5 +- > > drivers/net/qede/qede_ethdev.c | 1 + > > drivers/net/virtio/virtio_ethdev.c | 1 + > > drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 + > > lib/librte_ethdev/rte_ethdev.c | 44 +++++++++++++++++ > > lib/librte_ethdev/rte_ethdev.h | 4 ++ > > 22 files changed, 172 insertions(+), 6 deletions(-) > > > > -- > > 1.8.3.1 > > Regards, > > Bernard.

