Thanks, PSB.
> -----Original Message-----
> From: Ferruh Yigit <[email protected]>
> Sent: Thursday, November 7, 2019 10:26 PM
> To: Dekel Peled <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; Matan Azrad
> <[email protected]>; Shahaf Shuler <[email protected]>; Slava
> Ovsiienko <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> Thomas Monjalon <[email protected]>; [email protected];
> [email protected]; [email protected]
> Cc: [email protected]
> Subject: Re: [PATCH v4 3/3] app/testpmd: use API to set max LRO packet size
>
> On 11/7/2019 12:35 PM, Dekel Peled wrote:
> > This patch implements use of the API for LRO aggregated packet max
> > size.
> > It adds command-line and runtime commands to configure this value, and
> > adds option to show the supported value.
> > Documentation is updated accordingly.
> >
> > Signed-off-by: Dekel Peled <[email protected]>
>
> <...>
>
> > +cmdline_parse_inst_t cmd_config_max_lro_pkt_size = {
> > + .f = cmd_config_max_lro_pkt_size_parsed,
> > + .data = NULL,
> > + .help_str = "port config all max-lro-pkt-size <value>",
>
> Can you please update "cmd_help_long_parsed()" function to add this new
> command to the help output?
>
Will send v5 with update.
> <...>
>
> > @@ -419,6 +419,7 @@ struct fwd_engine * fwd_engines[] = { struct
> > rte_eth_rxmode rx_mode = {
> > .max_rx_pkt_len = RTE_ETHER_MAX_LEN,
> > /**< Default maximum frame length. */
> > + .max_lro_pkt_size = RTE_ETHER_MAX_LEN,
>
> If PMD value used if application doesn't provide a default value, my
> comment on previous patch, we can remove this value. So
> 'max_lro_pkt_size' can be used only set explicitly, otherwise used PMD
> values.
