Thanks Maxime. Go ahead, your proposal sounds good. Br, Zhike Wang JDCloud, Product Development, IaaS ------------------------------------------------------------------------------------------------ Mobile／+86 13466719566 E- mail／wangzh...@jd.com Address／5F Building A,North-Star Century Center,8 Beichen West Street,Chaoyang District Beijing Https://JDCloud.com ------------------------------------------------------------------------------------------------
-----Original Message----- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Thursday, November 14, 2019 4:53 PM To: Zhike Wang; dev@dpdk.org; sta...@dpdk.org; secur...@dpdk.org Cc: 王志克 Subject: Re: [dpdk-dev] [PATCH v2] vhost: fix vring message handling broken in some case Maybe change the title to something like: vhost: fix vring requests validation broken if no FD in payload On 11/13/19 12:03 PM, Zhike Wang wrote: > When VHOST_USER_VRING_NOFD_MASK is set, the fd_num is 0, > so validate_msg_fds() will return error. In this case, > the negotiation of vring message between vhost user front end and > back end would fail, and as a result, vhost user link could NOT be up. > > How to reproduce: > 1.Run dpdk testpmd insides VM, which locates at host with ovs+dpdk. > 2.Notice that inside ovs there are endless logs regarding failure to > handle VHOST_USER_SET_VRING_CALL, and link of vm could NOT be up. > > Fixes: bf47225 ("vhost: fix possible denial of service by leaking FDs") > Signed-off-by: Zhike Wang <wangzk...@163.com> > --- > lib/librte_vhost/vhost_user.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > otherwise: Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com> The title can be changed while applying if you agree with it, no need to send v3. I'll take care of the different backports. Thanks, Maxime
