11/11/2019 06:41, Gavin Hu:
> With "-march=armv8.2-a" specified, a compiling error generated:
> app/test/test_rcu_qsbr.c:234:10: error: comparison of integer
> expressions of different signedness: ‘unsigned int’ and ‘int’
> [-Werror=sign-compare]
>
> Fixes: b87089b0bb19 ("test/rcu: add API and functional tests")
> Cc: [email protected]
>
> Signed-off-by: Gavin Hu <[email protected]>
> Reviewed-by: Honnappa Nagarahalli <[email protected]>
> Reviewed-by: Steve Capper <[email protected]>
> ---
> --- a/app/test/test_rcu_qsbr.c
> +++ b/app/test/test_rcu_qsbr.c
> /* Skip one update */
> - if (i == (RTE_MAX_LCORE - 10))
> + if (i == (unsigned int)(RTE_MAX_LCORE - 10))
For N1 SDP, RTE_MAX_LCORE = 4.
So this test weird.
Why not using rand() to find a number between 0 and max ?
You are hiding a real failure with a forced type casting.
Please reviewers, explain why you think it is the right thing to do?
