> -----Original Message----- > From: David Marchand <[email protected]> > Sent: Thursday, November 21, 2019 5:30 AM > To: Thomas Monjalon <[email protected]> > Cc: Xu, Rosen <[email protected]>; dev <[email protected]>; Zhang, Tianfei > <[email protected]>; Pei, Andy <[email protected]>; Ye, Xiaolong > <[email protected]>; Yigit, Ferruh <[email protected]> > Subject: Re: [dpdk-dev] [PATCH v18 10/19] raw/ifpga: add SEU error handler > > On Wed, Nov 20, 2019 at 10:23 PM Thomas Monjalon <[email protected]> > wrote: > > > > Rosen (and most of your colleagues), > > Please use --in-reply-to when sending a new version. > > All versions must be a reply to the very first cover letter. > > > > 14/11/2019 10:02, Rosen Xu: > > > + IFPGA_RAWDEV_PMD_INFO("seu emr low: 0x%lx\n", val); > > > > Using %lx is usually wrong. > > val is 64-bit. > > On 32-bit machines (like some Intel ones), it does not compile. > > I had to fix it while pulling next-net. > > > > The same issue was in "raw/ifpga/base: clean fme errors". > > > > Please check 32-bit compilation.
You are correct, Thanks your point out and help to fix it. > > > > Note: we should have such check in the CI. > > https://git.dpdk.org/dpdk/commit/?id=3be76aa9294f3788b4f9c615642e6027f1b > 7948a > > -- > David Marchand
