> From: Stephen Hemminger <[email protected]> > Sent: Monday, November 25, 2019 9:13 AM > To: [email protected] > Cc: Stephen Hemminger <[email protected]>; [email protected]; > Dexuan Cui <[email protected]> > > In order to change RSS parameters, the host requires that RSS > is disable first. > > Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters") > Cc: [email protected] > Signed-off-by: Dexuan Cui <[email protected]> > Signed-off-by: Stephen Hemminger <[email protected]> > --- > drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c > index 164e9ad174a7..575780ee5f26 100644 > --- a/drivers/net/netvsc/hn_ethdev.c > +++ b/drivers/net/netvsc/hn_ethdev.c > @@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev > *dev, > hv->rss_ind[i] = reta_conf[idx].reta[shift]; > } > > + err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE); > + if (err) { > + PMD_DRV_LOG(NOTICE, > + "rss disable failed"); > + return err; > + } > + > err = hn_rndis_conf_rss(hv, 0); > if (err) { > PMD_DRV_LOG(NOTICE, > @@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev > *dev) > return err; > } > > + err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE); > + if (err) { > + PMD_DRV_LOG(NOTICE, > + "rss disable failed"); > + return err; > + } > + > err = hn_rndis_conf_rss(hv, 0); > if (err) { > PMD_DRV_LOG(NOTICE, > -- > 2.20.1
Hi, Stephen, I think the patch originally came from Donald Lee (I added him to "To"). IMO Donald's Signed-off-by should be added. And, can you please change my Signed-off-by to Tested-by? Thanks, -- Dexuan
