On 12/4/19 2:12 PM, David Marchand wrote:
> Fixed title s/unitialized/uninitialized/
>
> On Wed, Nov 27, 2019 at 11:32 PM Stephen Hemminger
> <[email protected]> wrote:
>>
>> Valgrind reports that eal interrupt thread is calling epoll_ctl
>> with uninitialized data. Trivial to fix by initializing it.
>
> Added a note on it being a Valgrind false positive.
>
>
>> Fixes: af75078fece3 ("first public release")
>> Cc: [email protected]
>
>> Signed-off-by: Stephen Hemminger <[email protected]>
> Acked-by: David Marchand <[email protected]>
>
> Applied, thanks.
It breaks build on RHEL 7.6 gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-36):
lib/librte_eal/linux/eal/eal_interrupts.c: In function
‘eal_intr_thread_main’:
lib/librte_eal/linux/eal/eal_interrupts.c:1048:9: error: missing
initializer for field ‘events’ of ‘struct epoll_event’
[-Werror=missing-field-initializers]
struct epoll_event ev = { };
^
In file included from lib/librte_eal/linu/eal/eal_interrupts.c:15:0:
/usr/include/sys/epoll.h:89:12: note: ‘events’ declared here
uint32_t events; /* Epoll events */
^
