On Mon, Dec 9, 2019 at 1:33 PM Anoob Joseph <[email protected]> wrote: > > Hi Jerin, > > Please see inline. > > Thanks, > Anoob > > > -----Original Message----- > > From: dev <[email protected]> On Behalf Of Jerin Jacob > > Sent: Monday, December 9, 2019 1:22 PM > > To: Anoob Joseph <[email protected]> > > Cc: Akhil Goyal <[email protected]>; Declan Doherty > > <[email protected]>; Thomas Monjalon <[email protected]>; > > Tejasree Kondoj <[email protected]>; Jerin Jacob Kollanukkaran > > <[email protected]>; Narayana Prasad Raju Athreya > > <[email protected]>; Kiran Kumar Kokkilagadda > > <[email protected]>; Nithin Kumar Dabilpuram > > <[email protected]>; Pavan Nikhilesh Bhagavatula > > <[email protected]>; Ankur Dwivedi <[email protected]>; > > Archana Muniganti <[email protected]>; Vamsi Krishna Attunuru > > <[email protected]>; Lukas Bartosik <[email protected]>; dpdk-dev > > <[email protected]> > > Subject: Re: [dpdk-dev] [PATCH 05/15] crypto/octeontx2: add security in eth > > dev > > configure > > > > On Sun, Dec 8, 2019 at 5:26 PM Anoob Joseph <[email protected]> wrote: > > > > > > From: Tejasree Kondoj <[email protected]> > > > > > > Adding security in eth device configure. > > > > > > Signed-off-by: Ankur Dwivedi <[email protected]> > > > Signed-off-by: Anoob Joseph <[email protected]> > > > Signed-off-by: Archana Muniganti <[email protected]> > > > Signed-off-by: Tejasree Kondoj <[email protected]> > > > Signed-off-by: Vamsi Attunuru <[email protected]> > > > --- > > > doc/guides/nics/octeontx2.rst | 20 +++++ > > > drivers/common/octeontx2/otx2_common.h | 4 + > > > drivers/crypto/octeontx2/Makefile | 2 +- > > > drivers/crypto/octeontx2/meson.build | 1 + > > > drivers/crypto/octeontx2/otx2_cryptodev.c | 2 + > > > drivers/crypto/octeontx2/otx2_ipsec_fp.h | 55 +++++++++++++ > > > drivers/crypto/octeontx2/otx2_security.c | 122 > > ++++++++++++++++++++++++++++ > > > drivers/crypto/octeontx2/otx2_security.h | 4 + > > > drivers/net/octeontx2/otx2_ethdev.c | 22 ++++- > > > drivers/net/octeontx2/otx2_ethdev.h | 2 + > > > drivers/net/octeontx2/otx2_ethdev_devargs.c | 19 +++++ > > > > Add "Inline crypto" feature in doc/guides/nics/features/octeontx2*.ini > > [Anoob] The feature is "Inline protocol" and it's not present in > doc/guides/nics/features/default.ini. Shall I update that file also with this > patch?
Yes. Please. Please update the generic doc update as a separate patch.

