On Wed, Dec 4, 2019 at 9:34 AM David Marchand <[email protected]> wrote: > > On Wed, Dec 4, 2019 at 9:33 AM David Marchand <[email protected]> > wrote: > > > > On Tue, Dec 3, 2019 at 10:15 PM Aaron Conole <[email protected]> wrote: > > > > > > The service_valid call is used without properly bounds checking the > > > input parameter. Almost all instances of the service_valid call are > > > inside a for() loop that prevents excessive walks, but some of the > > > public APIs don't bounds check and will pass invalid arguments. > > > > > > Prevent this by using SERVICE_GET_OR_ERR_RET where it makes sense, > > > and adding a bounds check to one service_valid() use. > > > > > > Fixes: 8d39d3e237c2 ("service: fix race in service on app lcore function") > > > Fixes: e9139a32f6e8 ("service: add function to run on app lcore") > > > Fixes: e30dd31847d2 ("service: add mechanism for quiescing") > Cc: [email protected] > > > > Signed-off-by: Aaron Conole <[email protected]> > > > > Reviewed-by: David Marchand <[email protected]>
Applied, thanks. -- David Marchand
