Hi Akhil, Please see inline.
Thanks, Archana > -----Original Message----- > From: Akhil Goyal <[email protected]> > Sent: Monday, January 6, 2020 3:09 PM > To: Archana Muniganti <[email protected]>; > [email protected]; [email protected] > Cc: Sucharitha Sarananaga <[email protected]>; Anoob Joseph > <[email protected]>; Abed Mohammad Kamaluddin > <[email protected]>; Jerin Jacob Kollanukkaran > <[email protected]>; [email protected]; [email protected] > Subject: [EXT] RE: [PATCH] examples/fips_validation: fix parsing of cipher > length for AES-GCM > > External Email > > ---------------------------------------------------------------------- > > From: Sucharitha Sarananaga <[email protected]> > > > > Cipher length need to be updated in case of AES-GCM decryption. > > > > Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing") > > > > Signed-off-by: Archana Muniganti <[email protected]> > > Signed-off-by: Sucharitha Sarananaga <[email protected]> > > --- > > examples/fips_validation/fips_validation_gcm.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/examples/fips_validation/fips_validation_gcm.c > > b/examples/fips_validation/fips_validation_gcm.c > > index ea48ddf..f295025 100644 > > --- a/examples/fips_validation/fips_validation_gcm.c > > +++ b/examples/fips_validation/fips_validation_gcm.c > > @@ -19,6 +19,7 @@ > > #define PTLEN_STR "PTlen = " > > #define AADLEN_STR "AADlen = " > > #define TAGLEN_STR "Taglen = " > > +#define CTLEN_STR "PTlen = " > Typo. Should be CTlen [Archana] NIST request file for AES-GCM test vectors contains 'PTlen =' field. This field holds plain text length when encrypt test vectors are used. And same field holds cipher text length when decrypt test vectors are used. Hence added a new macro that will be used in AES-GCM 'decryption'
