Re: [dpdk-dev] [PATCH v4 6/9] eal: add function to detect process type

[Pallavi Kadam]

On 1/8/2020 10:35 PM, Stephen Hemminger wrote:

On Wed,  8 Jan 2020 19:13:09 -0800
Pallavi Kadam <pallavi.ka...@intel.com> wrote:

Minor comments

  /* Address of global and public configuration */
-static struct rte_config rte_config;
+static struct rte_config rte_config = {
+               .mem_config = &early_mem_config,
+};

Only single tab is needed for indent here

+enum rte_proc_type_t
+       eal_proc_type_detect(void)

put function in column 1.

enum rte_proc_type_t
eal_proc_type_detect(void)

In a related vain, the existing code fore eal_create_cpu_map does
not follow DPDK coding style at all. It has weird indentation of
for loops and uses C99 style declarations of loop variables.
I guess nobody on Linux side ever looked at the Windows code for that.

Thanks, Stephen.
Will fix this single tab indent in v5.

Also, will send a new patch for eal_create_cpu_map function.
Can you please suggest what exact changes are required here.