17/01/2020 16:48, Honnappa Nagarahalli: > > > > > On 1/16/20 2:11 PM, Jerin Jacob wrote: > > > > > > On Thu, Dec 12, 2019 at 6:42 PM <jer...@marvell.com> wrote: > > > > > >> --- a/config/common_linux > > > > > >> +++ b/config/common_linux > > > > > >> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y > > > > > >> CONFIG_RTE_EXEC_ENV_LINUXAPP=y > > > > > >> > > > > > >> CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y > > > > > >> -CONFIG_RTE_EAL_IGB_UIO=y > > > > > >> CONFIG_RTE_EAL_VFIO=y > > > > > >> -CONFIG_RTE_KNI_KMOD=y > > > Suggest to keep the lines, but set them to 'n'. It will be easier to > > > enable.
Configs should be enabled in the generated .config, not in the versioned template. > > In config/common_base it is set as =n. it can be enabled there just like > > other > > config. > > I just did this way to have symmetry with other configs. > > Thoughts? > Sounds good. > CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV=n can also be removed as it is set in > common_base. > CONFIG_RTE_LIBRTE_VHOST_POSTCOPY is set to 'n' in common_linux, but it is not > present in common_base. Good catch. All options should be in common_base.