On 1/27/2020 3:34 AM, Stephen Hemminger wrote:
> The previous patch to change default IP addresses for tx only
> mode got the wrong values (typo).
>
> Fixes: bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP
> parameters")
> Cc: sta...@dpdk.org
> Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
> ---
> app/test-pmd/txonly.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c
> index 871cf6c1547f..4b5bec443b44 100644
> --- a/app/test-pmd/txonly.c
> +++ b/app/test-pmd/txonly.c
> @@ -45,8 +45,8 @@ uint16_t tx_udp_src_port = 9;
> uint16_t tx_udp_dst_port = 9;
>
> /* use RFC5735 / RFC2544 reserved network test addresses */
> -uint32_t tx_ip_src_addr = (192U << 24) | (18 << 16) | (0 << 8) | 1;
> -uint32_t tx_ip_dst_addr = (192U << 24) | (18 << 16) | (0 << 8) | 2;
> +uint32_t tx_ip_src_addr = (198U << 24) | (18 << 16) | (0 << 8) | 1;
> +uint32_t tx_ip_dst_addr = (198U << 24) | (18 << 16) | (0 << 8) | 2;
>
> #define IP_DEFTTL 64 /* from RFC 1340. */
>
I confirm from rfc5735:
198.18.0.0/15 - This block has been allocated for use in benchmark
tests of network interconnect devices. [RFC2544] explains that this
range was assigned to minimize the chance of conflict in case a
testing device were to be accidentally connected to part of the
Internet. Packets with source addresses from this range are not
meant to be forwarded across the Internet.
Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com>
Applied to dpdk-next-net/master, thanks.
