Hi Hariprasad,
> -----Original Message-----
> From: Govindharajan, Hariprasad <[email protected]>
> Sent: Thursday, February 20, 2020 1:27 PM
> To: Lu, Wenzhuo <[email protected]>; Wu, Jingjing
> <[email protected]>; Iremonger, Bernard
> <[email protected]>
> Cc: [email protected]; Yigit, Ferruh <[email protected]>;
> [email protected]; [email protected];
> Govindharajan, Hariprasad <[email protected]>
> Subject: [PATCH] app/testpmd: fix wrong return value in parse_port_list
>
> The function parse_port_list() is designed to return unsigned int value. After
> sanitizing the inputs, it is returning -1. Changed it to return 0.
>
> Fixes: 2df00d562d20 ("app/testpmd: add --portlist option")
> Cc: [email protected]
>
> Signed-off-by: Hariprasad Govindharajan
> <[email protected]>
> ---
> app/test-pmd/config.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> 9d95202..91db508 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -2642,7 +2642,7 @@ parse_port_list(const char *list, unsigned int
> *values, unsigned int maxsize)
> unsigned int marked[maxsize];
>
> if (list == NULL || values == NULL)
> - return -1;
> + return 0;
>
> for (i = 0; i < (int)maxsize; i++)
> marked[i] = 0;
> --
> 2.7.4
./devtools/check-git-log.sh -1
Wrong headline format:
app/testpmd: fix wrong return value in parse_port_list
Line too long:
Signed-off-by: Hariprasad Govindharajan
<[email protected]>
Otherwise:
Acked-by: Bernard Iremonger <[email protected]>
