28/02/2020 14:25, Thomas Monjalon: > In the check for the version of intel-ipsec-mb library, > there is a backslash in front of the #include. > This backslash is for escaping the hash sign parsed as > a number sign in make. > > Since make-4.3, escaping is not required for the number sign. > As a consequence, it resolves now to '\#': > > syntax error near unexpected token `|' > `grep -e "IMB_VERSION_STR" \#include <intel-ipsec-mb.h> | cut -d'"' -f2' > syntax error near unexpected token `|' > `grep -e "IMB_VERSION_NUM" \#include <intel-ipsec-mb.h> | cut -d' ' -f3' > > The makefiles are fixed by using a variable for the hash sign, > as recommended in make-4.3 changelog: > https://lists.gnu.org/archive/html/info-gnu/2020-01/msg00004.html > > Fixes: 3067c8ce77ac ("crypto/aesni_mb: fix build with custom dependency path") > Fixes: 457b8e372975 ("crypto/aesni_gcm: check dependency version with make") > Fixes: bf6eb2c22fd1 ("crypto/kasumi: use IPsec library") > Fixes: 7c87e2d7b359 ("crypto/snow3g: use IPsec library") > Fixes: 61f7c988e39e ("crypto/zuc: use IPsec library") > Cc: sta...@dpdk.org > > Signed-off-by: Thomas Monjalon <tho...@monjalon.net> > --- > > v2: > - found the root cause in make-4.3 > - use $H for compatibility with make < 4.3 > > Note the list of "Fixes" references are here to help backporting, > even if there was no bug before the recent release of make-4.3.
I was expecting some reviews and a merge in the crypto tree. Given it is blocking me to merge any other patch, after waiting 2 weeks, Applied in master branch.
