Hi Xiaojun, Comments inline.
Best Regards, Xiao > -----Original Message----- > From: Xiaojun Liu <xiaojun....@silicom.co.il> > Sent: Friday, February 28, 2020 4:38 PM > To: Wang, Xiao W <xiao.w.w...@intel.com>; Zhang, Qi Z > <qi.z.zh...@intel.com>; Kwan, Ngai-mint <ngai-mint.k...@intel.com>; Keller, > Jacob E <jacob.e.kel...@intel.com> > Cc: dev@dpdk.org; Xiaojun Liu <xiaojun....@silicom.co.il> > Subject: [PATCH v1 2/5] net/fm10k: add epl serdes and port control functions > > Add epl serdes include loading spico, > controlling pcsl, dma, dfe, ical. Add spico code. > Add state machine for epl lane and port, it creates > a pthread to handle the state changing event. > Add external port management, which will use > state machine to handle the event from lane and port. > The lane state will change between DOWN, WAIT_PLL_LOCK, > WAIT_SIGNAL_OK, WAIT_DFE_ICAL, WAIT_DFE_PCAL, UP. > The port state will change between DOWN, WAIT_LANE_UP, UP. > > To enable the switch management, you need add > CONFIG_RTE_FM10K_MANAGEMENT=y in > config/common_linux when building. No need to add above section in every patch. I suggest to put it into doc/guides/nics/fm10k.rst, and you can have a more detailed description about this big feature there. Please also check the empty lines and alignment issues.
