> -----Original Message-----
> From: Wu, Jingjing <jingjing...@intel.com>
> Sent: Monday, March 23, 2020 09:51
> To: Wang, Haiyue <haiyue.w...@intel.com>; dev@dpdk.org; Ye, Xiaolong 
> <xiaolong...@intel.com>; Zhang,
> Qi Z <qi.z.zh...@intel.com>; Yang, Qiming <qiming.y...@intel.com>; Xing, 
> Beilei <beilei.x...@intel.com>
> Cc: Zhao1, Wei <wei.zh...@intel.com>; Wang, Haiyue <haiyue.w...@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v1 1/4] net/iavf: stop the PCI probe in DCF 
> mode
> 
> +static int
> +handle_dcf_arg(__rte_unused const char *key, const char *value,
> +            __rte_unused void *arg)
> __rte_unused is not needed here.

Yes, has been rewritten and fixed in v3. ;-)

> 
> +{
> +     bool *dcf = arg;
> +
> +     if (arg == NULL || value == NULL)
> +             return -EINVAL;
> +
> +     if (strcmp(value, "dcf") == 0)
> +             *dcf = true;
> +     else
> +             *dcf = false;
> +
> +     return 0;
> +}
> +

Reply via email to