25/03/2020 15:11, Kevin Traynor: > This is a blunt way to remove this warning. > > Some alternatives are: > - disable the warning for individual components > - components rework to statically allocate memory for parts of structs > impacted > > Maybe there's some other solutions?
In general, I am against disabling warnings, neither globally nor specifically. Is there a way to hide false positives without disabling the warning? > Impacted components: > ../drivers/crypto/caam_jr/caam_jr_pvt.h > ../drivers/crypto/ccp/ccp_crypto.h > ../drivers/crypto/dpaa_sec/dpaa_sec.h > ../drivers/crypto/virtio/virtio_cryptodev.h > ../drivers/net/enic/base/vnic_dev.c > ../drivers/net/iavf/../../common/iavf/virtchnl.h > ../drivers/net/ice/base/ice_adminq_cmd.h > ../drivers/net/mlx4/mlx4_rxtx.c > ../drivers/net/qede/base/ecore_mcp.c > ../lib/librte_cryptodev/rte_cryptodev.h > ../lib/librte_pipeline/rte_table_action.c > > Full details in the Bugzilla: > https://bugs.dpdk.org/show_bug.cgi?id=421 Would be easier to provide explanations here. I think we need at least one false positive example. > Kevin Traynor (2): > meson: gcc 10 disable stringop-overflow warnings > mk: gcc 10 disable stringop-overflow warnings You don't need to split in 2 patches.
