-----Original Message-----
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Leyi Rong
Sent: Monday, March 16, 2020 3:46 PM
To: Zhang, Qi Z <qi.z.zh...@intel.com>; Ye, Xiaolong <xiaolong...@intel.com>
Cc: dev@dpdk.org; Rong, Leyi <leyi.r...@intel.com>
Subject: [dpdk-dev] [PATCH 07/12] net/iavf: add flow director enabled switch 
value

The commit adds fdir_enabled flag into iavf_adapter structure to identify if 
fdir id is active. Rx data path can be benefit if fdir id parsing is not 
needed, especially in vector path.

Signed-off-by: Leyi Rong <leyi.r...@intel.com>
---
 drivers/net/iavf/iavf.h      |  1 +
 drivers/net/iavf/iavf_rxtx.h | 26 ++++++++++++++++++++++++++
 2 files changed, 27 insertions(+)

diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h index 
4fe15237a..1918a67f1 100644
--- a/drivers/net/iavf/iavf.h
+++ b/drivers/net/iavf/iavf.h
@@ -142,6 +142,7 @@ struct iavf_adapter {
        bool tx_vec_allowed;
        const uint32_t *ptype_tbl;
        bool stopped;
+       uint8_t fdir_enabled;
 };
 
 /* IAVF_DEV_PRIVATE_TO */
diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h index 
c85207dae..5548d1adb 100644
--- a/drivers/net/iavf/iavf_rxtx.h
+++ b/drivers/net/iavf/iavf_rxtx.h
@@ -281,6 +281,32 @@ void iavf_dump_tx_descriptor(const struct iavf_tx_queue 
*txq,
               tx_desc->cmd_type_offset_bsz);
 }
 
+/* Enable/disable flow director Rx processing in data path. */ static 
+inline void iavf_fdir_rx_proc_enable(struct iavf_adapter *ad, bool on) 
+{
+       static uint32_t ref_cnt;
+
+       if (on) {
+               /* enable flow director processing */
+               if (ref_cnt++ == 0) {
+                       ad->fdir_enabled = on;
+                       PMD_DRV_LOG(DEBUG,
+                                   "FDIR processing on RX set to %d", on);
+               }
+       } else {
+               if (ref_cnt >= 1) {
+                       ref_cnt--;
+
+                       if (ref_cnt == 0) {
+                               ad->fdir_enabled = on;
+                               PMD_DRV_LOG(DEBUG,
+                                           "FDIR processing on RX set to %d", 
on);
+                       }
+               }
+       }
+}
+

fdir_enabled is used for fast path. To avoid competition, how about to make it 
in queue granularity?


 #ifdef RTE_LIBRTE_IAVF_DEBUG_DUMP_DESC
 #define IAVF_DUMP_RX_DESC(rxq, desc, rx_id) \
        iavf_dump_rx_descriptor(rxq, desc, rx_id)
--
2.17.1

Reply via email to