Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon <[email protected]>
> Sent: Wednesday, April 1, 2020 6:36 AM
> To: Joyce Kong <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; Honnappa
> Nagarahalli <[email protected]>; Phil Yang
> <[email protected]>; Gavin Hu <[email protected]>; nd
> <[email protected]>; [email protected]
> Subject: Re: [dpdk-dev] [PATCH v7 1/6] lib/eal: implement the family of PMD
> bit operation APIs
>
> Hi,
>
> 09/03/2020 10:54, Joyce Kong:
> > Bitwise operation APIs are defined and used in a lot of PMDs,
> > which caused a huge code duplication.
>
> Statistics of the series: 653 insertions(+), 326 deletions(-)
> I would not say it is a huge duplication.
We did not include all PMDs, just a few for piloting and seeking opinions.
It is a huge duplication when counting all the PMDs.
>
> > To reduce duplication,
> > this patch consolidates them into a common API family.
> [...]
> > +PMD Bitops
> > +M: Joyce Kong <[email protected]>
> > +F: lib/librte_eal/common/include/rte_pmd_bitops.h
>
> Why is it called PMD bitops and not simply bitops?
The scope of these APIs are decreased to PMD use only, for
libraries/applications, it is recommended to use C11 directly as there are
complications of more ordering models involved.
>
